Skip to content

Fix typos in error logging #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 19, 2018
Merged

Fix typos in error logging #654

merged 2 commits into from
Jan 19, 2018

Conversation

bboreham
Copy link
Contributor

Current code gives you this kind of thing:

ts=2018-01-15T15:01:20.02110214Z caller=log.go:108 level=error msg="Error looking for pending ingester: %v"
ts=2018-01-15T15:01:20.021162734Z caller=log.go:108 level=error msg="Failed to transfer chunks to another ingester: %v"

jml
jml approved these changes Jan 15, 2018
View reviewed changes
Copy link
Contributor

@jml jml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think this is mostly stuff that was missed in the great log migration.

@jml jml mentioned this pull request Jan 19, 2018
Merged
@rndstr
Copy link
Contributor

rndstr commented Jan 19, 2018

(Rebased)

@bboreham bboreham merged commit 3ddddfc into master Jan 19, 2018
@bboreham bboreham deleted the fix-ingester-log branch January 19, 2018 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jml jml jml approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bboreham @rndstr @jml